From 2c466d30464b566c471a89c5528d768be7729445 Mon Sep 17 00:00:00 2001 From: littleblack111 Date: Sat, 21 Jun 2025 20:19:27 +0800 Subject: style: remove uncessary comments and fixed clangd format fix(server/client:read): correctly set good = false and cb when failed --- src/server/server.cpp | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) (limited to 'src/server/server.cpp') diff --git a/src/server/server.cpp b/src/server/server.cpp index a368efc..c14a39e 100644 --- a/src/server/server.cpp +++ b/src/server/server.cpp @@ -12,33 +12,27 @@ namespace LibSock { namespace Server { Server::Server(uint16_t port, bool reuseaddr, bool keepalive) - : m_sockfd( - std::make_shared(socket(AF_INET, SOCK_STREAM, 0)) - ) + : m_sockfd(std::make_shared(socket(AF_INET, SOCK_STREAM, 0))) , m_port(port) { if (pServer) throw std::runtime_error("server:server Server already exist"); - std::lock_guard - lk(m_mutex); + std::lock_guard lk(m_mutex); if (!m_sockfd->isValid() || m_sockfd->get() < 0) throw std::runtime_error("server:server Failed to create socket"); constexpr int opt = 1; constexpr int size = sizeof(opt); - if (keepalive && - setsockopt(m_sockfd->get(), SOL_SOCKET, SO_REUSEADDR, &opt, size) < 0) + if (keepalive && setsockopt(m_sockfd->get(), SOL_SOCKET, SO_REUSEADDR, &opt, size) < 0) throw std::runtime_error("server:server setsockopt(SO_REUSEADDR) failed"); - if (reuseaddr && - setsockopt(m_sockfd->get(), SOL_SOCKET, SO_KEEPALIVE, &opt, size) < 0) + if (reuseaddr && setsockopt(m_sockfd->get(), SOL_SOCKET, SO_KEEPALIVE, &opt, size) < 0) throw std::runtime_error("server:server setsockopt(SO_KEEPALIVE) failed"); memset(&m_addr, 0, sizeof(m_addr)); m_addr.sin_family = AF_INET; m_addr.sin_port = htons(m_port); m_addr.sin_addr.s_addr = INADDR_ANY; - if (bind(m_sockfd->get(), reinterpret_cast(&m_addr), sizeof(m_addr)) || - listen(m_sockfd->get(), 5)) + if (bind(m_sockfd->get(), reinterpret_cast(&m_addr), sizeof(m_addr)) || listen(m_sockfd->get(), 5)) throw std::runtime_error("server:server Failed to bind or listen on socket"); } -- cgit v1.2.3