From 2c466d30464b566c471a89c5528d768be7729445 Mon Sep 17 00:00:00 2001 From: littleblack111 Date: Sat, 21 Jun 2025 20:19:27 +0800 Subject: style: remove uncessary comments and fixed clangd format fix(server/client:read): correctly set good = false and cb when failed --- src/server/client.cpp | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) (limited to 'src/server/client.cpp') diff --git a/src/server/client.cpp b/src/server/client.cpp index 333f734..d89aea0 100644 --- a/src/server/client.cpp +++ b/src/server/client.cpp @@ -37,9 +37,6 @@ Client::Client(SP server, SP clients, bool track, bool oneShot) } Client::~Client() { -#ifdef DEBUG - onDisconnect(); -#endif m_sockfd.reset(); } @@ -58,17 +55,15 @@ void Client::recvLoop() { } bool SRecvData::isEmpty() const { - return data.empty() || - std::ranges::all_of(data, [](char c) { return std::isspace(c); }); + return data.empty() || std::ranges::all_of(data, [](char c) { return std::isspace(c); }); } void SRecvData::sanitize() { if (!data.empty() && data.back() == '\n') data.pop_back(); - data.erase(std::remove(data.begin(), data.end(), asciiEscape), - data.end()); // don't accept ASCII code, might mess up terminal - // // NOLINT + data.erase(std::remove(data.begin(), data.end(), asciiEscape), data.end()); // don't accept ASCII code, might mess up terminal + // // NOLINT if (const auto start = data.find_first_not_of(" \t\r\n"); start != std::string::npos) { @@ -93,9 +88,6 @@ UP Client::read(std::optionalgood = true; } -#ifdef DEBUG - onRecv(*recvData); -#endif m_szReading.reset(); return recvData; } @@ -121,9 +113,7 @@ bool Client::isValid() { int err = 0; socklen_t size = sizeof(err); - return getsockopt(m_sockfd->get(), SOL_SOCKET, SO_ERROR, &err, &size) >= - 0 && - err == 0; + return getsockopt(m_sockfd->get(), SOL_SOCKET, SO_ERROR, &err, &size) >= 0 && err == 0; } bool Client::write(const std::string &msg, std::optional> cb) { -- cgit v1.2.3