diff options
| author | littleblack111 <littleblack11111@gmail.com> | 2025-06-18 12:37:19 +0800 |
|---|---|---|
| committer | littleblack111 <littleblack11111@gmail.com> | 2025-06-18 13:54:59 +0800 |
| commit | 2405f25c6b5e1c824599b8a4d76e6bda0b083849 (patch) | |
| tree | 74607a16284b610f4d54545616d5949adb01bf00 /src | |
| parent | f5aacb29f5f238ae9121bf43d96ad2eba361e7b7 (diff) | |
internal: remove unused m_name
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/client.cpp | 6 | ||||
| -rw-r--r-- | src/server/clients.cpp | 20 |
2 files changed, 3 insertions, 23 deletions
diff --git a/src/server/client.cpp b/src/server/client.cpp index f8dc1ca..e5fab6b 100644 --- a/src/server/client.cpp +++ b/src/server/client.cpp @@ -41,7 +41,7 @@ Client::~Client() { void Client::recvLoop() { while (true) { - auto recvData = read(std::format("{}: ", m_name)); + auto recvData = read(); if (!recvData->good) break; @@ -114,7 +114,7 @@ void Client::run() { } bool Client::isValid() { - if (!m_sockfd->isValid() || m_name.empty()) + if (!m_sockfd->isValid()) return false; int err = 0; @@ -135,8 +135,6 @@ bool Client::write(const std::string &msg, std::optional<std::function<std::any( return r; } -const std::string &Client::getName() const { return m_name; } - const std::string &Client::getIp() const { return m_ip; } template <typename... Args> diff --git a/src/server/clients.cpp b/src/server/clients.cpp index 1a11ed7..4d6308e 100644 --- a/src/server/clients.cpp +++ b/src/server/clients.cpp @@ -68,24 +68,6 @@ void Clients::broadcast(const SData &msg) { m_vDatas.push_back(msg); } -bool Clients::nameExists(const std::string &name) { - auto it = std::ranges::find_if(m_vClients, [&name](const auto &s) { return s.second->getName() == name; }); - - if (it != m_vClients.end()) { - if (!it->second->isValid()) { - kick(std::weak_ptr<Client>(it->second), true, "Connection lost"); - return false; - } - return true; - } - return false; -} - -SP<Client> Clients::getByName(const std::string &name) const { - auto it = std::ranges::find_if(m_vClients, [&name](const auto &s) { return s.second->getName() == name; }); - return it != m_vClients.end() ? it->second : nullptr; -} - SP<Client> Clients::getByIp(const std::string &ip) const { auto it = std::ranges::find_if(m_vClients, [&ip](const auto &s) { return s.second->getIp() == ip; }); return it != m_vClients.end() ? it->second : nullptr; @@ -106,7 +88,7 @@ void Clients::kick(WP<Client> clientWeak, const bool kill, const std::string &re for (auto it = m_vClients.begin(); it != m_vClients.end(); ++it) { if (it->second == client) { - if (client && !client->getName().empty()) + if (client) // this only exist when the client is registered // not sure why the second is null if (cb) |
