From 35ab6da1aa6b6f02dd4b58740645de505aa1a406 Mon Sep 17 00:00:00 2001 From: littleblack111 Date: Sat, 31 May 2025 19:48:22 +0800 Subject: Revert "style: clang-tidy" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit aa84ff9d0cd2b31cda6e6b55b4f36cec7e61eec0. not sure why.. ``` src/session.cpp:105:19: error: no matching function for call to ‘std::__cxx11::basic_string::erase(std::ranges::borrowed_subrange_t&>, std::__cxx11::basic_string::iterator)’ 105 | data.erase(std::ranges::remove(data, asciiEscape), data.end()); // don't accept ASCII code, might mess up terminal | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/session.cpp:105:19: note: there are 3 candidates In file included from /usr/include/c++/15.1.1/string:56, from /usr/include/c++/15.1.1/bits/locale_classes.h:42, from /usr/include/c++/15.1.1/bits/ios_base.h:43, from /usr/include/c++/15.1.1/ios:46, from /usr/include/c++/15.1.1/bits/ostream.h:43, from /usr/include/c++/15.1.1/bits/unique_ptr.h:43, from /usr/include/c++/15.1.1/memory:80, from src/chatManager.hpp:3, from src/session.hpp:4, from src/session.cpp:1: /usr/include/c++/15.1.1/bits/basic_string.h:2323:7: note: candidate 1: ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::erase(size_type, size_type) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator; size_type = long unsigned int]’ 2323 | erase(size_type __pos = 0, size_type __n = npos) | ^~~~~ /usr/include/c++/15.1.1/bits/basic_string.h:2323:23: note: no known conversion for argument 1 from ‘std::ranges::borrowed_subrange_t&>’ to ‘std::__cxx11::basic_string::size_type’ {aka ‘long unsigned int’} 2323 | erase(size_type __pos = 0, size_type __n = npos) | ~~~~~~~~~~^~~~~~~~~ /usr/include/c++/15.1.1/bits/basic_string.h:2343:7: note: candidate 2: ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::iterator std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::erase(__const_iterator) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator; iterator = std::__cxx11::basic_string::iterator; __const_iterator = std::__cxx11::basic_string::const_iterator]’ 2343 | erase(__const_iterator __position) | ^~~~~ /usr/include/c++/15.1.1/bits/basic_string.h:2343:7: note: candidate expects 1 argument, 2 provided /usr/include/c++/15.1.1/bits/basic_string.h:2363:7: note: candidate 3: ‘constexpr std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::iterator std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::erase(__const_iterator, __const_iterator) [with _CharT = char; _Traits = std::char_traits; _Alloc = std::allocator; iterator = std::__cxx11::basic_string::iterator; __const_iterator = std::__cxx11::basic_string::const_iterator]’ 2363 | erase(__const_iterator __first, __const_iterator __last) | ^~~~~ /usr/include/c++/15.1.1/bits/basic_string.h:2363:30: note: no known conversion for argument 1 from ‘std::ranges::borrowed_subrange_t&>’ to ‘std::__cxx11::basic_string::__const_iterator’ {aka ‘std::__cxx11::basic_string::const_iterator’} 2363 | erase(__const_iterator __first, __const_iterator __last) | ~~~~~~~~~~~~~~~~~^~~~~~~ make: *** [Makefile:73: build/session.o] Error 1 make: *** Waiting for unfinished jobs.... ``` --- src/session.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/session.cpp b/src/session.cpp index 4f7cfa6..79caede 100644 --- a/src/session.cpp +++ b/src/session.cpp @@ -102,7 +102,7 @@ void CSession::SRecvData::sanitize() { if (!data.empty() && data.back() == '\n') data.pop_back(); - data.erase(std::ranges::remove(data, asciiEscape), data.end()); // don't accept ASCII code, might mess up terminal + data.erase(std::remove(data.begin(), data.end(), asciiEscape), data.end()); // don't accept ASCII code, might mess up terminal // NOLINT if (const auto start = data.find_first_not_of(" \t\r\n"); start != std::string::npos) { const auto end = data.find_last_not_of(" \t\r\n"); -- cgit v1.2.3