From ced38b1b0f46f9fbdf9d37644d27bdbd2a29af1d Mon Sep 17 00:00:00 2001 From: Tom Englund Date: Sun, 24 Aug 2025 09:57:37 +0200 Subject: disable buffer readability checks on intel (#11515) * dmabuf: disable buffer read check on intel readability checks directly on buffer fds on some intel laptops is broken, see https://gitlab.freedesktop.org/drm/intel/-/issues/9415 * sync: use rvalue ref in addwaiter doonreadable use rvalue reference in addwaiter and doonreadable, because we store the function in the SReadableWaiter a lot of the time, move it into place there when that happends or let it go out of scope after function call. --- src/protocols/core/Compositor.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/protocols/core/Compositor.cpp') diff --git a/src/protocols/core/Compositor.cpp b/src/protocols/core/Compositor.cpp index 73326990..a859148f 100644 --- a/src/protocols/core/Compositor.cpp +++ b/src/protocols/core/Compositor.cpp @@ -161,7 +161,7 @@ CWLSurfaceResource::CWLSurfaceResource(SP resource_) : m_resource(re if (state->updated.bits.acquire) { // wait on acquire point for this surface, from explicit sync protocol - state->acquire.addWaiter(whenReadable); + state->acquire.addWaiter(std::move(whenReadable)); } else if (state->buffer->isSynchronous()) { // synchronous (shm) buffers can be read immediately whenReadable(); @@ -170,7 +170,7 @@ CWLSurfaceResource::CWLSurfaceResource(SP resource_) : m_resource(re auto syncFd = dc(state->buffer.m_buffer.get())->exportSyncFile(); if (syncFd.isValid()) - g_pEventLoopManager->doOnReadable(std::move(syncFd), whenReadable); + g_pEventLoopManager->doOnReadable(std::move(syncFd), std::move(whenReadable)); else whenReadable(); } else { -- cgit v1.2.3