From 6594b50e57935dd66930ccd35dba7a1b4131399d Mon Sep 17 00:00:00 2001 From: memchr <118117622+memchr@users.noreply.github.com> Date: Wed, 20 Sep 2023 07:26:20 +0000 Subject: logging/format: use std::format_string to catch formatting string errors at compile time (#3377) * fix(log): use constexpr format string * deprecate getFormat --- src/helpers/MiscFunctions.hpp | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) (limited to 'src/helpers/MiscFunctions.hpp') diff --git a/src/helpers/MiscFunctions.hpp b/src/helpers/MiscFunctions.hpp index f53ab4e8..429f381f 100644 --- a/src/helpers/MiscFunctions.hpp +++ b/src/helpers/MiscFunctions.hpp @@ -32,26 +32,10 @@ std::string replaceInString(std::string subject, const std: std::vector getBacktrace(); void throwError(const std::string& err); -// why, C++. -void sendToLog(uint8_t, const std::string&); template -std::string getFormat(const std::string& fmt, Args&&... args) { - std::string fmtdMsg; - - try { - fmtdMsg += std::vformat(fmt, std::make_format_args(args...)); - } catch (std::exception& e) { - std::string exceptionMsg = e.what(); - sendToLog(2, std::format("caught exception in getFormat: {}", exceptionMsg)); - - const auto CALLSTACK = getBacktrace(); - - sendToLog(0, "stacktrace:"); - - for (size_t i = 0; i < CALLSTACK.size(); ++i) { - sendToLog(1, std::format("\t #{} | {}", i, CALLSTACK[i].desc)); - } - } - - return fmtdMsg; +[[deprecated("use std::format instead")]] std::string getFormat(std::format_string fmt, Args&&... args) { + // no need for try {} catch {} because std::format_string ensures that vformat never throw std::format_error + // because any suck format specifier will cause a compilation error + // this is actually what std::format in stdlib does + return std::vformat(fmt.get(), std::make_format_args(args...)); } \ No newline at end of file -- cgit v1.2.3