From b2c34404777ea0850f90f4c38f64484f03599d14 Mon Sep 17 00:00:00 2001 From: GartoxFR Date: Sat, 2 Mar 2024 01:35:17 +0100 Subject: animations: Refactor AnimatedVariable (#4911) * animation: Refactor AnimatedVariable This commit decomposes the AnimatedVariable class into a base class with the common attribute to all variable types and a templated derived type containing strongly typed info on the type being animated. Access to the typed version is perfomed using the visitor pattern. A utility is provided to build a visitor on the fly using lambdas. Adding a new type to be animated should just be a matter of adding the typed in the list defined by the ANIMABLE_TYPES macro The size of the commit is justified by the API change in the AnimatedVariable class. No more vec(), fl() or col() method but a unified value() method. * animation: Remove visitor pattern * animation: Fix coding style * animation: Fix coding style --- src/events/Layers.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/events/Layers.cpp') diff --git a/src/events/Layers.cpp b/src/events/Layers.cpp index 7dbcc7b1..2d94f1ed 100644 --- a/src/events/Layers.cpp +++ b/src/events/Layers.cpp @@ -327,13 +327,13 @@ void Events::listener_commitLayerSurface(void* owner, void* data) { } } - if (layersurface->realPosition.goalv() != layersurface->geometry.pos()) { + if (layersurface->realPosition.goal() != layersurface->geometry.pos()) { if (layersurface->realPosition.isBeingAnimated()) layersurface->realPosition = layersurface->geometry.pos(); else layersurface->realPosition.setValueAndWarp(layersurface->geometry.pos()); } - if (layersurface->realSize.goalv() != layersurface->geometry.size()) { + if (layersurface->realSize.goal() != layersurface->geometry.size()) { if (layersurface->realSize.isBeingAnimated()) layersurface->realSize = layersurface->geometry.size(); else -- cgit v1.2.3