summaryrefslogtreecommitdiff
path: root/src/protocols/core
Commit message (Collapse)AuthorAgeFilesLines
* internal: Fix compiler warnings (#9646)Lee Bousfield2025-03-171-2/+0
|
* syncobj: use eventfd instead of stalling fd checks (#9437)Tom Englund2025-03-144-77/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * syncobj: cleanup and use uniqueptrs cleanup a bit missing removals if resource not good, erasing from containers etc. make use of unique ptrs instead. and add default destructors. * syncobj: rework syncobj entirerly remove early buffer release that was breaking explicit sync, the buffer needs to exist until the surface commit event has been emitted and draw calls added egl sync points, move to eventfd signaling instead of stalling sync point checks, and recommit pending commits if waiting on a signal. add a CDRMSyncPointState helper class. move a few weak pointers to shared pointers so they dont destruct before we need to use them. * syncobj: queue pending states for eventfd eventfd requires us to queue pending stats until ready and then apply to current, and also when no ready state exist commit the client commit on the current existing buffer, if there is one. * syncobj: clear current buffer damage clear current buffer damage on current buffer commits. * syncobj: cleanup code and fix hyprlock remove unused code, and ensure we dont commit a empty texture causing locksession protocol and gtk4-layer-shell misbehaving. * syncobj: ensure buffers are cleaned up ensure the containers having the various buffers actually gets cleaned up from their containers, incase the CSignal isnt signaled because of expired smart pointers or just wrong order destruction because mishaps. also move the acquire/point setting to buffer attaching. instead of on precommit. * syncobj: remove unused code, optimize remove unused code and merge sync fds if fence is valid, remove manual directscanout buffer dropping that signals release point on pageflip, it can cause us to signal the release point while still keeping the current buffer and rendering it yet again causing wrong things. * syncobj: delay buffer release on non syncobj delay buffer releases on non syncobj surfaces until next commit, and check on async buffers if syncobj and drop and signal the release point on backend buffer release. * syncobj: ensure we follow protocol ensure we follow protocol by replacing acquire/release points if they arrive late and replace already existing ones. also remove unneded brackets, and dont try to manual lock/release buffers when it comes to explicit protocol. it doesnt care about buffer releases only about acquire and release points and signaling them. * syncobj: lets not complicate things set points in precommit, before checking protocol errors and we catch any pending acquire/release points arriving late. * syncobj: move SSurfaceState to types remove destructor resource destroying, let resources destroys them on their events, and move SSurfaceStates to types/SurfaceState.hpp * syncobj: actually store the merged fd have to actually store the mergedfd to use it. * syncobj: cleanup a bit around fences ensure the current asynchronous buffer is actually released on pageflip not the previous. cleanup a bit FD handling in commitPendingAndDoExplicitSync, and reuse the in fence when syncing surfaces. * syncobjs: ensure fence FD doesnt leak calling resetexplicitfence without properly ensuring the FD is closed before will leak it, store it per monitor and let it close itself with the CFileDescriptor class. * syncobj: ensure buffers are actually released buffers were never being sent released properly. * types: Defer buffer sync releaser until unlock * syncobj: store directscanout fence in monitor ensure the infence fd survives the scope of attemptdirectscanout so it doesnt close before it should have. * syncobj: check if if acquire is expired we might hit a race to finish on exit where the timeline just has destructed but the buffer waiter is still pending. and such we removeAllWaiters null dereferences. * syncobj: code style changes remove quack comment, change to m_foo and use a std::vector and weakpointer in the waiter for removal instead of a std::list. * syncobj: remove unused async buffer drop remove unused async buffer drop, only related to directscanout and is handled elsewhere. --------- Co-authored-by: Lee Bousfield <ljbousfield@gmail.com>
* renderer: skip ds commits if buffer didn't change (#9556)Ikalco2025-03-081-12/+2
| | | | this fixes direct scanout glitches by ensuring that attemptDirectScanout doesn't try to recommit the same buffer to AQ which would cause a pageflip event and the backendRelease to release the same buffer too early
* protocols: Support wp color management proto (#9444)UjinT342025-02-262-11/+30
| | | Adds support for the recently merged w-p CM protocol alongside the (now deprecated) old CM WIP protocols
* xwayland: improve dnd and cleanup (#9405)nyx2025-02-242-26/+38
| | | | | | | Minor changes to xwayland dnd / regular dnd to fix various issues --------- Co-authored-by: Vaxry <vaxry@vaxry.net>
* datadevice: fix wrong param (#9370)Honkazel2025-02-081-1/+1
| | | Reason: look at the setReceive parameters and also at the next line(tries to narrow)
* protocols: Support content-type-v1 proto (#9226)UjinT342025-02-021-0/+2
|
* popup: take xdg geometry into account in input calcsVaxry2025-02-011-3/+1
| | | | fixes #9023
* core: begin using CFileDescriptor from hyprutils (#9122)Tom Englund2025-01-305-48/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * config: make fd use CFileDescriptor make use of the new hyprutils CFileDescriptor instead of manual FD handling. * hyprctl: make fd use CFileDescriptor make use of the new hyprutils CFileDescriptor instead of manual FD handling. * ikeyboard: make fd use CFileDescriptor make use of the new CFileDescriptor instead of manual FD handling, also in sendKeymap remove dead code, it already early returns if keyboard isnt valid, and dont try to close the FD that ikeyboard owns. * core: make SHMFile functions use CFileDescriptor make SHMFile misc functions use CFileDescriptor and its associated usage in dmabuf and keyboard. * core: make explicit sync use CFileDescriptor begin using CFileDescriptor in explicit sync and its timelines and eglsync usage in opengl, there is still a bit left with manual handling that requires future aquamarine change aswell. * eventmgr: make fd and sockets use CFileDescriptor make use of the hyprutils CFileDescriptor instead of manual FD and socket handling and closing. * eventloopmgr: make timerfd use CFileDescriptor make the timerfd use CFileDescriptor instead of manual fd handling * opengl: make gbm fd use CFileDescriptor make the gbm rendernode fd use CFileDescriptor instead of manual fd handling * core: make selection source/offer use CFileDescriptor make data selection source and offers use CFileDescriptor and its associated use in xwm and protocols * protocols: convert protocols fd to CFileDescriptor make most fd handling use CFileDescriptor in protocols * shm: make SHMPool use CfileDescriptor make SHMPool use CFileDescriptor instead of manual fd handling. * opengl: duplicate fd with CFileDescriptor duplicate fenceFD with CFileDescriptor duplicate instead. * xwayland: make sockets and fds use CFileDescriptor instead of manual opening/closing make sockets and fds use CFileDescriptor * keybindmgr: make sockets and fds use CFileDescriptor make sockets and fds use CFileDescriptor instead of manual handling.
* core,hyprctl: clang, clang-tidy, typo fixes and dtors changes (#9233)Honkazel2025-01-302-5/+1
| | | | | | | * declare dtor once + DMABBUF typo fix * dup include + clang moment * linux-dmabuf: last minute nit change
* renderer/internal: stop using box pointersVaxry2025-01-261-1/+1
| | | | in favor of const refs
* input: abord dnd op on escape pressedVaxry2025-01-242-0/+9
| | | | ref #9154
* core: move all shared_ptrs from the STL to hyprutils (#9143)Vaxry2025-01-236-6/+0
|
* core: add LIKELY and UNLIKELY macrosvaxerski2025-01-176-62/+62
| | | | helps the compiler optimize
* core: cleanup header includes (#9088)user1111111111111111111111111111111112025-01-172-1/+5
| | | Cleanup some unneeded includes to speed up compilation
* core: Add render:allow_early_buffer_release to make buffer release ↵UjinT342025-01-101-5/+10
| | | | configurable (#9019)
* core: Add support for HDR and color management protocols (#8715)UjinT342025-01-071-0/+3
|
* core/compositor: fix too early buffer release (#8966)UjinT342025-01-061-4/+4
|
* datadevice: guard XWayland server against crashesvaxerski2025-01-061-1/+1
| | | | | | The server might be dead or restarting, and we'd deref null ref #7822
* dnd/seat: avoid sending button events during a dnd opvaxerski2025-01-021-1/+1
| | | | fixes #8781
* Renderer: rewrite render scheduling (#8683)Vaxry2024-12-223-4/+12
| | | This rewrites renderer scheduling. Occlusion is now unified in a new Pass type.
* data-device: fix edge case crash on null xwmVaxry2024-12-211-6/+8
| | | | fixes #8787
* internal: remove dead code (#8748)Ikalco2024-12-171-1/+0
|
* xwayland: Support cross DnD from Wayland (#8708)Vaxry2024-12-152-60/+160
| | | Adds support for drag-and-drop from Wayland clients to XWayland ones
* core/data: Use pointer focus for DnD operations (#8707)Vaxry2024-12-142-13/+28
| | | fixes #7737
* data-device: fixup wrong box expansionVaxry2024-12-121-2/+2
| | | | oopsie 7c03e9d376abe5308c47772b4c17a9c345788f60 was wrong
* core/data-device: expand damage region to fix minor px errorsVaxry2024-12-111-1/+1
| | | | fixes #7656
* core/output: don't send enter too aggresivelyVaxry2024-12-101-1/+1
| | | | | | sometimes this might be like 1px and send enter to the wrong output fixes #8654
* core: Add clang-tidy (#8664)Vaxry2024-12-073-11/+11
| | | | | This adds a .clang-tidy file for us. It's not a strict requirement to be compliant, but I tuned it to be alright.
* seat: fix double scrolling in some applications (#8583)Ikalco2024-11-262-0/+5
|
* shm: fix shm fd size check before creating or resizing shm_pool (#8572)Nabil Otsmane2024-11-251-0/+21
| | | | | * protocols: fix shm fd size check before creating or resizing shm_pool * added static to function
* pointer: add drm dumb buffers for cursors (#8399)Vaxry2024-11-142-7/+21
| | | | | --------- Co-authored-by: Mihai Fufezan <mihai@fufexan.net>
* internal: more profiling less calls and local copies (#8300)Tom Englund2024-10-301-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * compositor: reduce amount of window box copies mousemoveunified can call this very frequently, the cbox copying actually shows up as an impact in such cases, move it down in the scope and only do it when necessery. * core: constify and reference frequent calls profiling shows these as frequent called functions try to reduce the amount of copies with references and const the variables. * pointermgr: remove not used local copy, const ref remove unneded local copies and const ref cursorsize. * inputmgr: reduce amount of calls to vectortowindow the amount of calls to g_pCompositor->vectorToWindowUnified fast ramps up in cpu usage with enough windows existing and moving the mouse, move the PWINDOWIDEAL up and reuse it if its already the same. * protocol: compositor remove unused local copy remove unused local copy of accumulateCurrentBufferDamage and const previousBuffer. * renderer: reduce scope of variables and refactor move a few variables down in their scopes to reduce the amount of calls and copies when not needed, also add one more for loop in renderWorkspaceWindows and store the windows in a vector with weakpointers that should be rendered, this adds a loop but reduces the amount of repeated calls to shouldRenderWindow and also makes the rest of the loops go over way smaller vector when many windows exist.
* seat: avoid sending pointless 'keymap' and 'repeat_info' events (#8276)staticssleever6682024-10-282-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #### Describe your PR, what does it fix/add? Fix lag spikes when pressing more than 6 keys at the same time. #### Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.) Debugging process: <details> This is triggered by typing some applications, like CopyQ or XWayland. Typing in Firefox doesn't lead to lag, however it itself does lag handling these events. Profiling CopyQ shows that paths leading to `QtWaylandClient::QWaylandInputDevice::Keyboard::keyboard` take over 80% of processing time of an otherwise idle program. Looking at output of 'wev' even when it's not focused shows same events received over and over again. ``` [14: wl_keyboard] repeat_info: rate: 25 keys/sec; delay: 300 ms [14: wl_keyboard] keymap: format: 1 (xkb v1), size: 64754 ``` Looking at what passes through CInputManager::onKeyboardKey() -> CSeatManager::setKeyboard() shows Hyprland 'switching' between endpoints of the same keyboard, one of them being named like the other but with '-1' suffix. </details> Tested changing layouts in Fcitx5 and with following config. ``` input:kb_layout = us,cz input:kb_variant = ,qwerty input:kb_options = grp:alt_shift_toggle ``` Also tested changing 'input:repeat_delay' while running. Curiously, now these events appear in the output of 'wev' only once. Changing layouts still seems to work fine though. #### Is it ready for merging, or does it need work? Ready for merging.
* internal: few more marginal optimisations from profiling (#8271)Tom Englund2024-10-282-2/+3
| | | | | | | | | | | | | | | | | * deco: reduce local temporars and function calls profiling shows this is a high used function, reduce the amount of function calls and local temporar copies and also check if we even need to add extents at all in the loop. * popup: optimize bfhelper in popups pass nodes as const reference and reserve the size of the children node vector help reduce the reallocations. * procotol: make compositor bfhelper use const ref use const ref for nodes and reserve second nodes vector size to reduce amount of reallocation needed.
* internal: cleanup CMonitor usage and fix a few ref hogsVaxry2024-10-264-13/+13
| | | | ref #8221
* internal: Move CMonitor to SP (#8178)Vaxry2024-10-192-2/+2
| | | | | * move monitors to sp * XD
* output: send enter events on late wl_output bindsVaxry2024-10-163-0/+29
| | | | fixes #6560
* output: update state even if no owner exists (#8044)trianta2024-10-091-1/+1
|
* output/xdg-output: avoid sending events to released globalsVaxry2024-10-091-1/+4
| | | | ref #6835
* wayland/output: send geometry in updateStateVaxry2024-09-301-2/+3
|
* shm: send a static list of shm formatsVaxry2024-09-201-5/+2
| | | | fixes #7733
* data-device: conform to reported source actionsvaxerski2024-09-172-4/+20
| | | | fixes #7815
* data-device: don't send default action of moveVaxry2024-09-141-3/+1
| | | | gtk doesn't like it?
* data-device: send clock time in motion eventsVaxry2024-09-141-1/+4
| | | | remove hack
* presentation-feedback: minor fixupsVaxry2024-08-302-2/+2
|
* data-device: send dndFinished when dnd offer is destroyed while unfinishedVaxry2024-08-282-1/+11
| | | | | | | | fixes #7496 see https://invent.kde.org/plasma/kwin/-/commit/711c5bb43f2823766d5189dc8d567c8f4cec253c see https://bugs.kde.org/show_bug.cgi\?id\=482142
* misc: constify the remaining for loops (#7534)Tom Englund2024-08-266-14/+14
| | | now we roll loops at blazing constified speed.
* core: make most for loops use const references (#7527)Tom Englund2024-08-264-10/+10
| | | | why not let the compiler optimise things for us at hyprspeeds when we can.
* output: dont cast enum out of range (#7448)Tom Englund2024-08-211-1/+1
| | | | avoid casting non typed enum out of range, looks like WL_OUTPUT_MODE_CURRENT was the intention here.