summaryrefslogtreecommitdiff
path: root/src/managers/SeatManager.cpp
Commit message (Collapse)AuthorAgeFilesLines
* seat: fix dropped wl_keyboard.enter after stale keyboardFocusResource (#14143)Psilocybin782026-04-271-25/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * seat: fix dropped wl_keyboard.enter after stale keyboardFocusResource CSeatManager::setKeyboardFocus's leave loop was gated on m_state.keyboardFocusResource (a WP<CWLSeatResource>). That weak pointer can expire between focus cycles — most reliably via the explicit `.reset()` in KeybindManager::passKeys for XWayland targets, but also in practice after certain wl_seat rebind sequences from toolkit-level churn. When the WP is expired, the leave loop's `if (m_state.keyboardFocusResource)` is false, the loop is skipped, and no wl_keyboard.leave is sent for the previous focus. The old client's CWLKeyboardResource keeps m_currentSurface pointing at its old surface. On the next focus back to that surface, CWLKeyboardResource::sendEnter's per-keyboard dedup fires (`if (m_currentSurface == surface) return;`) and the enter is silently dropped. Net result: client believes it's still focused, compositor routes keys via m_state.keyboardFocusResource which now points somewhere else, typed keystrokes silently go to a different window. A mouse drag resyncs because InputManager::processMouseDownNormal → refocus() → mouseMoveUnified(refocus=true) → rawWindowFocus(…, foundSurface) takes a different path that forces the leave/enter pair through. Reported and reproducible in discussion #14141. Fix: iterate PROTO::seat->m_keyboards (the global owning list) in the leave loop and let sendLeave()'s own m_currentSurface gate decide whether each keyboard needs the event. sendLeave() and the sendMods(0,…) that precedes it are already gated on m_currentSurface being set, so iterating every keyboard is a no-op for any keyboard that wasn't on the previous focus — identical semantics to the old code in the healthy case, correct in the broken case. Enter loop unchanged: it's driven by surf->client() which is a cached wl_client* on the surface resource, stable across cycles. Verified against the repro in #14141 (two wev instances cycled via `hyprctl dispatch focuswindow`). Before the fix both windows get stuck in a "I am focused" state after ~3 cycles. After the fix leave/enter pair each dispatch cleanly. * seat: apply same leave-loop fix to setPointerFocus Identical failure mode to the keyboard case in the previous commit: setPointerFocus's leave loop is gated on m_state.pointerFocusResource, which can expire between focus changes. When it does, the leave is skipped, the previously-focused client's wl_pointer m_currentSurface stays stuck, and the next sendEnter's per-pointer dedup silently drops the enter. sendPointerButton also early-returns on `if (!m_state.pointerFocusResource)`, so the visible symptom is "a click on a taskbar / dock / menu button doesn't register after a layer-shell Overlay surface appeared or disappeared, until the user moves the mouse." Motion re-syncs focus via InputManager::mouseMoveUnified → setPointerFocus with a fresh resource, at which point clicks work again. Fix is the same: iterate PROTO::seat->m_pointers and let sendLeave's m_currentSurface gate decide. No-op for pointers not on the old surface.
* config/lua: init lua config manager, use lua if available (#13817)Vaxry2026-04-261-1/+1
| | | Adds a new lua config manager, which will automatically be used if there is a lua config present.
* seat/compositor: fix minor issues (#13958)Pppp11162026-04-021-2/+4
|
* event: refactor HookSystem into a typed event bus (#13333)Vaxry2026-02-221-1/+0
| | | | | Refactors the old HookSystem into a typed event bus with clear separation, discovery and types.
* layout: rethonk layouts from the ground up (#12890)Vaxry2026-02-211-2/+2
| | | | | Rewrites layouts to be much smaller, and deal with much less annoying BS. Improves the overall architecture, unifies handling of pseudotiling, and various other improvements.
* layershell: restore focus to layer shell surface after popup is destroyed ↵Aurelle2026-02-091-13/+22
| | | | (#13225)
* debug: move to hyprutils' logger (#12673)Vaxry2025-12-181-8/+8
|
* desktop: cleanup, unify desktop elements as views (#12563)Vaxry2025-12-081-13/+13
|
* compositor: Configurable behavior when window to be focused conflicts with ↵Nikolai Nechaev2025-11-251-3/+4
| | | | | | | | | | fullscreen (#12033) Renames `misc:new_window_takes_over_fullscreen` into `misc:on_focus_under_fullscreen` and implements the following behavior: - By default, when a tiling window is being focused on a workspace where a fullscreen/maximized window exists, respect the `misc:on_focus_under_fullscreen` config variable.
* input: fix refocus on grab dismiss (#12014)0rtz2025-10-201-1/+48
|
* seat: release depressed modifiers on leave (#11854)usering-around2025-09-281-0/+1
|
* protocols: implement pointer-warp-v1 (#11469)Ikalco2025-08-291-2/+3
|
* protocols: implement ext-data-control (#11323)Nihal Jere2025-08-151-0/+3
| | | This protocol has superseded wlr-data-control
* virtualkeyboard: Add options to skip releasing pressed keys on close and to ↵JS Deck2025-08-041-1/+17
| | | | skip sharing key states (#11214)
* core: use new typed signals from hu (#10853)outfoxxed2025-07-081-8/+8
|
* internal: refactor to use empty() (#10599)Kamikadze2025-05-311-1/+1
|
* refactor: use std::ranges whenever possible (#10584)Kamikadze2025-05-301-1/+1
|
* protocols: refactor class member vars (types) (#10261)davc0n2025-05-031-2/+2
|
* protocols: refactor class member vars (core) (#10259)davc0n2025-05-031-22/+22
|
* managers: refactor class member vars (#10242)davc0n2025-05-021-137/+137
|
* devices: refactor class member vars (#10206)davc0n2025-04-291-4/+4
|
* layers: refactor class member vars (#10149)davc0n2025-04-241-1/+1
| | | | | * layers: refactor class member vars * popups: rename m_WLSurface to m_wlSurface
* compositor: refactor class member vars (#10141)davc0n2025-04-221-2/+2
|
* seatmgr: avoid crash on null surfsVaxry2025-03-181-2/+2
|
* datadevice: do the unfocus surface stuff before dndActive is true (#9157)Maximilian Seidler2025-01-241-1/+1
|
* core: cleanup header includes (#9088)user1111111111111111111111111111111112025-01-171-0/+3
| | | Cleanup some unneeded includes to speed up compilation
* dnd/seat: avoid sending button events during a dnd opvaxerski2025-01-021-1/+1
| | | | fixes #8781
* core/data: Use pointer focus for DnD operations (#8707)Vaxry2024-12-141-4/+11
| | | fixes #7737
* core: Add clang-tidy (#8664)Vaxry2024-12-071-1/+1
| | | | | This adds a .clang-tidy file for us. It's not a strict requirement to be compliant, but I tuned it to be alright.
* seat: fix double scrolling in some applications (#8583)Ikalco2024-11-261-2/+4
|
* input: try to refocus a focusable window when seat grabs are reset (#7669)outfoxxed2024-09-071-0/+31
|
* misc: constify the remaining for loops (#7534)Tom Englund2024-08-261-1/+1
| | | now we roll loops at blazing constified speed.
* core: make most for loops use const references (#7527)Tom Englund2024-08-261-35/+35
| | | | why not let the compiler optimise things for us at hyprspeeds when we can.
* Core: Move to aquamarine (#6608)Vaxry2024-07-211-5/+5
| | | | | | | | | | | | | | Moves Hyprland from wlroots to aquamarine for the backend. --------- Signed-off-by: Vaxry <vaxry@vaxry.net> Co-authored-by: Mihai Fufezan <mihai@fufexan.net> Co-authored-by: Jan Beich <jbeich@FreeBSD.org> Co-authored-by: vaxerski <vaxerski@users.noreply.github.com> Co-authored-by: UjinT34 <41110182+UjinT34@users.noreply.github.com> Co-authored-by: Tom Englund <tomenglund26@gmail.com> Co-authored-by: Ikalco <73481042+ikalco@users.noreply.github.com> Co-authored-by: diniamo <diniamo53@gmail.com>
* input: Emulate discrete scrolling from v120 events (#6881)Agent00Ming2024-07-181-3/+1
| | | | | | | * seat: avoid sending axis_stop() when source is wheel * fix rounding for absolute discrete values greater than 1 Co-authored-by: Agent_00Ming <agent00ming9366@gmail.com>
* seat/dnd: unfocus pointer from surfaces on dnd startVaxry2024-06-161-0/+5
| | | | | | | | GTK is speshyal and requires this for functioning properly. Ugh. It's technically not required by spec, f you gtk. Ref #6509
* seatmgr: fix missing nullcheck in updateActiveKeyboardDataVaxry2024-06-121-1/+1
| | | | | | sometimes we may set a keyboard that's about-to-be-deleted, we might as well check for that additionally avoid setting null keyboards altogether
* seat: fixup touch event handlingvaxerski2024-06-121-25/+25
| | | | fixes #6353
* seat: fix pointer frame events not being sent correctlyVaxry2024-06-091-4/+1
| | | | fixes #6384
* wayland/core: move to new impl (#6268)Vaxry2024-06-081-26/+24
| | | | | * wayland/core/dmabuf: move to new impl it's the final countdown
* seat: send events to all bound seats for a clientVaxry2024-06-071-47/+99
| | | | | | some apps are legitimately braindead and bind wl_seat a bazillion times and expect the events to be sent to all of them ref #6159
* seat: discrete round away from zero + high res scrolling (#6317)Agent00Ming2024-06-031-2/+4
| | | | | | | | * Discrete scrolling round away from zero e.deltaDiscrete can be multiples of 30 instead of the usual 120 causing the rounded value to be 0 when too small causing erratic scrolling. * Send value120 alongside discrete Fixes sensitivity issues for clients that support value120 axis events
* xwayland: move to hyprland impl (#6086)Vaxry2024-05-251-0/+4
|
* seat: update keymap/repeat info on keymap events from keebsVaxry2024-05-171-3/+8
| | | | fixes #6114
* seat: Send discrete event when axis source is scroll wheel (#6103)Agent00Ming2024-05-161-0/+3
| | | | | | modified: src/managers/SeatManager.cpp modified: src/managers/input/InputManager.cpp Co-authored-by: Agent_00Ming <agent00ming9366@gmail.com>
* seat: send axis_stop events after axis eventsVaxry2024-05-151-0/+3
| | | | fixes #6090
* seat: send enter/leave events to all bound wl_seats for a clientVaxry2024-05-151-37/+59
| | | | | | fixes #6069 Will not send anything beyond enter/leave. If you depend on multiple seats sending you motion, button, etc, events, fix your app.
* wl_seat: send frame event after pointer leave (#6074)Sungyoon Cho2024-05-151-1/+16
|
* primary-selection: move to hyprland implVaxry2024-05-141-1/+25
|
* wlr-data-device: move to hyprland implVaxry2024-05-141-0/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2026-11-01 15:11:25 +0000