summaryrefslogtreecommitdiff
path: root/src/desktop/view/Window.cpp
Commit message (Collapse)AuthorAgeFilesLines
* algo/scrolling: various scrolling view related bugfixes (#13974)erstarr2026-05-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * fix scrolling view move when a grouped window is closed - prevent redundant space assignment for a grouped window that's about to be unmapped, add a `FOCUS_REASON` for unmapping grouped windows * fix focus_fallback after unmapping a window floating moving view * fix view change when changing workspaces (special and normal). add an optional `RECALCULATE_REASON` parameter to `recalculate()` calls of all algorithms. add an optional `RECALCULATE_MONITOR_REASON` parameter to `recalculateMonitor()` calls. add 2 new `FOCUS_REASON`s, for workspace change and special workspace toggle * Fix hyprctl keyword causing scrolling view move. rename INPUT_MODE_KB to INPUT_MODE_HARD since it seems to have little to do with keybinds * fix fullscreen/maximise moving the scrolling view * fix opening of layer 3 programs moving scrolling view * refactor, clean up and clang-format * fix bad decisions * fix includes, clang-format. * remove TODO * `focuswindow` no longer moves scrolling view when `follow_focus = 0` * fix: changes in a group's current window no longer casues scrolling view shift when `follow_focus = 0` * fix: `moveintogroup`, `movewindoworgroup` no longer causes scrolling view change if `follow_focus = 0` * clang-format * add `RECALCULATE_REASON_UNKNOWN`, `RECALCULATE_MONITOR_REASON_UNKNOWN`, `REMOVE_FROM_GROUP_REASON_UNKNOWN` remove optional wrapper from their enums, refactor code to work with the change * dispatches that call `switchtoWindow()` in CKeybindManager no longer cause scrolling view to move if `follow_focus = 0`. They still cause the move if `follow_focus = 1` Dispatches effected by this: `movefocus`, `cyclenext`, `focuscurrentorlast`, `focuscurrentorurgent` * Fix for Lua: switchToWondow * Fix for Lua: focus({window}) * Fix for Lua: Move Window Into Group * clang-format * Drop `hyprctl keyword` change * test: `focus({window})` with `follow_focus = false` * test: `focus({window})` with `follow_focus = true` * test: test Focus Fallback * test: Focus Fallback with groups * test: workspace change * test: special workspace toggle * test: workspace change - special to special also minor refactoring * test: close window in a group * test: move window into group `follow_focus = false` minor fix in test: expect -> assert * test: move window into group `follow_focus = true` * test: new layer * test: maximise fix in test: expect to assert. * test: fullscreen * test: `dispatch window.focus({ direction })` when `follow_focus = false` * test: `dispatch window.focus({ direction })` when `follow_focus = true` test-fix: expect -> assert * test: move focus within group when `follow_focus = false` * test: move focus within group when `follow_focus = true` * test-fix: kill all layers before killing all windows in layers test. prevents internal post test cleanup function failing to kill all layers test-fix: maximized and fullscreen swapped between their tests test-fix: testScrollingViewBehaviourMoveFocusInGroupFollowFocusTrue missing layout initialization test-fix: testScrollingViewBehaviourWorkspaceChange, testScrollingViewBehaviourCloseWindowInGroup have stale window class in a comment clang-format * catch up with main: move to new test function * clean-up the clean-up part of the tests: redundant * clang-format * pain * suffering: fix rebase fail * test: manually kill all layers since the cleanup function fails * remove test: fullscreen and maximise. scrolling has its own behaviour now
* layout/scrolling: handle fullscreen manually (#14190)Vaxry2026-05-071-5/+12
| | | Makes scroll handle fullscreen by itself, allowing for fs scrolls.
* desktop/window: refactor over fullscreen stateVaxry2026-04-291-1/+49
|
* desktop/window: expand hidden into proper statesVaxry2026-04-291-5/+40
|
* desktop/window: add alpha container for alpha calculationsVaxry2026-04-291-25/+63
|
* workspace: remove deprecated and unused members (#14198)ImperishableSecret2026-04-281-9/+0
| | | Clean up CWorkspace by removing deprecated m_defaultFloating, m_defaultPseudo, and unused m_wlrCoordinateArr
* config/lua: add ExpressionVec2, allow using a table for vec2 rules (#14197)Vaxry2026-04-281-7/+11
|
* desktop/view: fix SIGABRT in CWindow::onUnmap when monitor is expired (#14148)xxyangyoulin2026-04-271-2/+5
| | | | | | m_monitor is a WP<CMonitor> (weak_ptr). In onUnmap(), calling m_monitor->activeWorkspaceID() without .lock() causes SIGABRT when the monitor has been destroyed before the XWayland unmap event arrives, e.g. when a window on a special workspace is unmapped.
* config/lua: init lua config manager, use lua if available (#13817)Vaxry2026-04-261-65/+71
| | | Adds a new lua config manager, which will automatically be used if there is a lua config present.
* input: fix focus_on_close=2 (MRU) routing to cursor path instead of ↵Lucas Zanoni⠀⠀⠀⠀⠀ ⠀╱|、 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀ (˚ˎ 。7 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀ |、˜〵 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀じしˍ,)ノ2026-04-121-1/+1
| | | | getNextCandidate (#13969)
* desktop/popup: cache tree countVaxry2026-04-071-4/+5
|
* desktop/popup: cache popup extentsVaxry2026-04-071-17/+1
| | | | caches popup extents in the head to avoid potentially expensive traversals
* xwayland: pipe through monitor in coordinate mapping (#13700)Andreas Backx2026-04-051-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | * xwayland: prefer monitor-aware hover coords Introduce monitor-aware XWayland coordinate helpers and keep the X11 hover path anchored to the main surface box while preserving detailed debug logging, reducing dependence on nearest-monitor guesses in layout-sensitive input paths. * xwayland: use window monitor for reported coords Report X11 window positions through the window's known monitor instead of the generic nearest-monitor heuristic so boundary-aligned outputs keep stable XWayland coordinates. * xwayland: use window monitor for real position restore Convert XWayland geometry back into compositor space using the window's current monitor when available so vertically offset layouts do not round-trip through the wrong output. * xwayland: use window monitor for unmanaged geometry Restore override-redirect X11 geometry through the window's known monitor so helper windows and popups avoid nearest-monitor misclassification on offset layouts. * xwayland: remove monitor conversion debug logging Drop the temporary XWayland hover and coordinate conversion diagnostics now that the monitor-selection bug is confirmed and the window-monitor based conversions fix the issue. * xwayland: drop unrelated focused-motion change Remove the exploratory X11-specific pointer focus scaling from InputManager so the monitor mapping fix stays narrowly scoped to the XWayland coordinate conversion changes that actually resolve the bug. * clang-format XWaylandManager
* desktop/window: optimize getRealBorderSize()Vaxry2026-04-041-2/+14
|
* desktop/window: reduce window deco updates (#13980)Vaxry2026-04-041-3/+12
| | | AVARDAMAGE_ENTIRE doesn't mean the geometry changed, so no point in an expensive update
* desktop/reserved: do not crash on invalid box init (#13880)Vaxry2026-03-281-0/+3
| | | ref #13879
* desktop/window: guard null monitor in xwaylandSizeToReal (#13876)xxyangyoulin2026-03-281-1/+1
|
* renderer/deco: add glow decoration (#13862)Vaxry2026-03-271-0/+15
|
* config: cleanup the entire config infrastructure (#13785)Vaxry2026-03-201-45/+53
| | | | Massively refactors the config infrastructure, sorely needed and will be req'd for the lua stuff
* window/rules: add scrolling_width (#13754)ItsOhen2026-03-171-2/+2
|
* desktop/rules: fix static rules and content type. (#13725)ItsOhen2026-03-151-4/+10
| | | | Hopefully for the last time in a while. Also a lot easier to add in new static types with the recheck done in window map instead of the rule.
* renderer: refactor resources and flags (#13471)UjinT342026-03-071-6/+0
|
* desktop/rules: fix empty workspace handling (#13544)justin40462026-03-051-2/+3
|
* desktop/window: don't group modalsVaxry2026-03-031-0/+1
|
* desktop/window: fix floating windows being auto-grouped (#13475)André Silva2026-03-031-5/+6
| | | | | --------- Co-authored-by: Aqa-Ib <16420574+Aqa-Ib@users.noreply.github.com>
* hyprctl: fix workspace dynamic effect reloading (#13537)Vaxry2026-03-031-8/+6
| | | ref https://github.com/hyprwm/Hyprland/discussions/12806
* desktop/window: fix idealBB reserved (#13421)Vaxry2026-02-281-1/+1
| | | ref https://github.com/hyprwm/Hyprland/discussions/12766\#discussioncomment-15955638
* xwayland: normalize OR geometry to logical coords with force_zero_scaling ↵Skidam2026-02-251-12/+13
| | | | | (#13359) Fixes X11 popups, tooltips, and menus showing black boxes on scaled monitors with xwayland:force_zero_scaling = 1 #13334
* event: refactor HookSystem into a typed event bus (#13333)Vaxry2026-02-221-8/+10
| | | | | Refactors the old HookSystem into a typed event bus with clear separation, discovery and types.
* protocols: implement image-capture-source-v1 and image-copy-capture-v1 (#11709)Ikalco2026-02-221-0/+16
| | | Implements the new screencopy protocols
* layout: rethonk layouts from the ground up (#12890)Vaxry2026-02-211-411/+133
| | | | | Rewrites layouts to be much smaller, and deal with much less annoying BS. Improves the overall architecture, unifies handling of pseudotiling, and various other improvements.
* desktop/window: add stable id and use it for foreignVaxry2026-02-191-2/+6
|
* xwayland: fix size mismatch for no scaling (#13263)bea4dev2026-02-151-1/+2
|
* renderer: fix mouse motion in VRR (#12665)Szwagi2026-01-311-14/+1
|
* desktop/window: avoid uaf on instant removal of a windowVaxry2026-01-161-5/+5
| | | | ref https://github.com/hyprwm/Hyprland/discussions/12999
* desktop/window: track explicit workspace assignments to prevent X11 ↵John Mylchreest2026-01-091-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | configure overwrites (#12850) * fix: track explicit workspace assignments to prevent X11 configure overwrites Instead of only checking for special workspaces, track when workspaces are explicitly assigned via window rules or user actions (movetoworkspace). This prevents onX11ConfigureRequest from overwriting any explicit workspace assignment based on window position. Changes: - Add m_workspaceExplicitlyAssigned flag to CWindow - Set flag when window rules assign workspace - Set flag when user moves window via dispatcher - Check flag in onX11ConfigureRequest instead of just special workspace - Add debug logging for explicit workspace assignments * fix: simplify X11 configure request handling for special workspaces X11 apps send configure requests with positions based on XWayland's monitor layout, which could incorrectly move windows off special workspaces. Skip workspace reassignment when the window is on a special workspace or staying on the same monitor, but always run z-order, fullscreen flag, and damage logic since the configure request may include geometry changes.
* desktop/window: catch bad any cast tokensVaxry2026-01-051-8/+12
|
* dekstop/window: read static rules before guessing initial size if possible ↵Vaxry2026-01-011-0/+3
| | | | (#12783)
* desktop/window: use workArea for idealBB (#12802)Vaxry2026-01-011-11/+15
|
* desktop/window: go back to the previously focused window in a group (#12763)Vaxry2025-12-301-1/+18
|
* rules/windowRuleApplicator: fix min/max size effects (#12491)Vaxry2025-12-271-31/+42
| | | fixes #12412
* desktop/window: improve fullscreen handling for grouped windowsVaxry2025-12-221-17/+37
| | | | fixes #12700
* Desktop/history: Move history to desktop (#12676)Vaxry2025-12-201-1/+2
|
* debug: move to hyprutils' logger (#12673)Vaxry2025-12-181-32/+33
|
* desktop/windowRule: force center and move rules to override each other (#12618)Lichie2025-12-171-1/+1
|
* desktop/windowRules: fix disabling binary window rules with override (#12635)Lichie2025-12-151-13/+6
|
* animation: migrate PHLANIMVAR from SP to UP (#12486)Maximilian Seidler2025-12-141-10/+7
|
* window: only damage floating on clamped size change (#12633)Tom Englund2025-12-111-6/+11
| | | | | | | | | currently it damage the entire window if its floating and not x11 nor fullscreen meaning damage isnt working at all for floating. im tracing this back to a364df4 where the logic changed from damaging window only if size was being forced to now unconditonally doing it. change clampWindowSize to return as a bool if size changed and only damage window if it got clamped.
* desktop/view: use aliveAndVisible for most things (#12631)Vaxry2025-12-111-1/+1
|
* desktop: cleanup, unify desktop elements as views (#12563)Vaxry2025-12-081-0/+2703