diff options
| author | Lee Bousfield <ljbousfield@gmail.com> | 2025-03-18 18:46:28 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-19 00:46:28 +0100 |
| commit | c8d80a292012f036e1a1d3eb3b0501e3e3917872 (patch) | |
| tree | bfeb4363137d01ff6da191bec5ea0b9ce69f88a9 /src | |
| parent | 03385fc07f82bb891ded33db464397d867eb503d (diff) | |
ci: Fail on warnings (#9668)
* ci: Fail on warnings
* misc: Fix compiler warnings
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/PluginAPI.hpp | 11 | ||||
| -rw-r--r-- | src/protocols/FrogColorManagement.cpp | 7 | ||||
| -rw-r--r-- | src/protocols/XXColorManagement.cpp | 1 |
3 files changed, 13 insertions, 6 deletions
diff --git a/src/plugins/PluginAPI.hpp b/src/plugins/PluginAPI.hpp index fbacbaab..0f333294 100644 --- a/src/plugins/PluginAPI.hpp +++ b/src/plugins/PluginAPI.hpp @@ -61,9 +61,10 @@ struct SVersionInfo { // C ABI is needed to prevent symbol mangling, but we don't actually need C compatibility, // so we ignore this warning about return types that are potentially incompatible with C. -// Clang supports this pragma too. -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wreturn-type-c-linkage" +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wreturn-type-c-linkage" +#endif class IHyprLayout; class CWindow; @@ -322,4 +323,6 @@ APICALL inline EXPORT const char* __hyprland_api_get_client_hash() { } // NOLINTEND -#pragma GCC diagnostic pop +#ifdef __clang__ +#pragma clang diagnostic pop +#endif diff --git a/src/protocols/FrogColorManagement.cpp b/src/protocols/FrogColorManagement.cpp index 65afa75e..99bdb2bb 100644 --- a/src/protocols/FrogColorManagement.cpp +++ b/src/protocols/FrogColorManagement.cpp @@ -1,5 +1,6 @@ #include "FrogColorManagement.hpp" #include "color-management-v1.hpp" +#include "macros.hpp" #include "protocols/ColorManagement.hpp" #include "protocols/core/Subcompositor.hpp" #include "protocols/types/ColorManagement.hpp" @@ -13,6 +14,7 @@ static wpColorManagerV1TransferFunction getWPTransferFunction(frogColorManagedSu case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_GAMMA_22: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_GAMMA22; case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_ST2084_PQ: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_ST2084_PQ; case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_SCRGB_LINEAR: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_EXT_LINEAR; + default: UNREACHABLE(); } } @@ -103,9 +105,10 @@ CFrogColorManagementSurface::CFrogColorManagementSurface(SP<CFrogColorManagedSur surface->colorManagement->m_imageDescription.transferFunction = convertTransferFunction(getWPTransferFunction(FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_ST2084_PQ)); break; - }; // intended fall through + }; + [[fallthrough]]; case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_UNDEFINED: - case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_SCRGB_LINEAR: LOGM(TRACE, "FIXME: add tf support for {}", (uint32_t)tf); // intended fall through + case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_SCRGB_LINEAR: LOGM(TRACE, "FIXME: add tf support for {}", (uint32_t)tf); [[fallthrough]]; case FROG_COLOR_MANAGED_SURFACE_TRANSFER_FUNCTION_SRGB: surface->colorManagement->m_imageDescription.transferFunction = convertTransferFunction(getWPTransferFunction(tf)); diff --git a/src/protocols/XXColorManagement.cpp b/src/protocols/XXColorManagement.cpp index 36ace0f2..056a2cef 100644 --- a/src/protocols/XXColorManagement.cpp +++ b/src/protocols/XXColorManagement.cpp @@ -23,6 +23,7 @@ static wpColorManagerV1TransferFunction getWPTransferFunction(xxColorManagerV4Tr case XX_COLOR_MANAGER_V4_TRANSFER_FUNCTION_ST2084_PQ: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_ST2084_PQ; case XX_COLOR_MANAGER_V4_TRANSFER_FUNCTION_ST428: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_ST428; case XX_COLOR_MANAGER_V4_TRANSFER_FUNCTION_HLG: return WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_HLG; + default: UNREACHABLE(); } } |