surface: add virtual destructor to surfacerole to avoid undefined behaviour (#6620)

* surfacerole: add virtual destructor

all classes that will be derived from should have a virtual destructor
otherwise deleting an instance via pointer to a base class is undefined
behaviour, layershell/xdgshell hits this with std::default_delete in the
new sharedptr implentation.

* includes: fix missing includes

fix missing includes for no precompiled headers builds, and remove a
redefiniton of a macro already defined in macros.hpp

1 files changed, 1 insertions, 0 deletions

diff --git a/src/protocols/types/SurfaceRole.hpp b/src/protocols/types/SurfaceRole.hpp
index 05c0ea66..faaf70ee 100644
--- a/src/protocols/types/SurfaceRole.hpp
+++ b/src/protocols/types/SurfaceRole.hpp
@@ -11,4 +11,5 @@ enum eSurfaceRole {
 class ISurfaceRole {
   public:
     virtual eSurfaceRole role() = 0;
+    virtual ~ISurfaceRole()     = default;
 };