core/surface: fixup a few pointer handling edge cases

2 files changed, 9 insertions, 2 deletions

diff --git a/src/protocols/core/Compositor.cpp b/src/protocols/core/Compositor.cpp
index 6352b7e6..43d3059b 100644
--- a/src/protocols/core/Compositor.cpp
+++ b/src/protocols/core/Compositor.cpp
@@ -156,6 +156,7 @@ void CWLSurfaceResource::destroy() {
         unmap();
     }
     events.destroy.emit();
+    releaseBuffers(false);
     PROTO::compositor->destroyResource(this);
 }
 
@@ -338,13 +339,18 @@ void CWLSurfaceResource::unmap() {
     // release the buffers.
     // this is necessary for XWayland to function correctly,
     // as it does not unmap via the traditional commit(null buffer) method, but via the X11 protocol.
+    releaseBuffers();
+}
+
+void CWLSurfaceResource::releaseBuffers(bool onlyCurrent) {
     if (current.buffer && !current.buffer->resource->released)
         current.buffer->sendRelease();
-    if (pending.buffer && !pending.buffer->resource->released)
+    if (pending.buffer && !pending.buffer->resource->released && !onlyCurrent)
         pending.buffer->sendRelease();
 
     pending.buffer.reset();
-    current.buffer.reset();
+    if (!onlyCurrent)
+        current.buffer.reset();
 }
 
 void CWLSurfaceResource::error(int code, const std::string& str) {
diff --git a/src/protocols/core/Compositor.hpp b/src/protocols/core/Compositor.hpp
index 1fa6926a..79cd1de6 100644
--- a/src/protocols/core/Compositor.hpp
+++ b/src/protocols/core/Compositor.hpp
@@ -137,6 +137,7 @@ class CWLSurfaceResource {
     int            stateLocks = 0;
 
     void           destroy();
+    void           releaseBuffers(bool onlyCurrent = true);
     void           commitPendingState();
     void           bfHelper(std::vector<SP<CWLSurfaceResource>> nodes, std::function<void(SP<CWLSurfaceResource>, const Vector2D&, void*)> fn, void* data);
 };