summaryrefslogtreecommitdiff
path: root/src/protocols/WaylandProtocol.hpp
diff options
context:
space:
mode:
authorTom Englund <tomenglund26@gmail.com>2024-07-29 19:19:47 +0200
committerVaxry <vaxry@vaxry.net>2024-07-29 19:29:08 +0200
commit9c38b0fdbe32dc2cb81d53c9be90113d114f1cd2 (patch)
tree1e7b6c42be23f8164e5dd0742d3b131b2850cd01 /src/protocols/WaylandProtocol.hpp
parent60b663e2765c4cdb7e14fff75c4f88bf7ae312e2 (diff)
core: add a destructor to CHyprOpenglImpl and avoid wl_container_of undefined behaviour (#7101)
* protocols: avoid undefined behaviour in C macro to safely use wl_container_of with a class the class has to be no virtual functions, no inheritance, and uniform access control (e.g all public) work around this by putting this into a destroywrapper struct. * opengl: clean memory on destruction add a destructor and free the allocated memory and close the fd
Diffstat (limited to 'src/protocols/WaylandProtocol.hpp')
-rw-r--r--src/protocols/WaylandProtocol.hpp8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/protocols/WaylandProtocol.hpp b/src/protocols/WaylandProtocol.hpp
index 6154fa30..4d4e7925 100644
--- a/src/protocols/WaylandProtocol.hpp
+++ b/src/protocols/WaylandProtocol.hpp
@@ -11,6 +11,12 @@
#define PROTO NProtocols
+class IWaylandProtocol;
+struct IWaylandProtocolDestroyWrapper {
+ wl_listener listener;
+ IWaylandProtocol* parent = nullptr;
+};
+
class IWaylandProtocol {
public:
IWaylandProtocol(const wl_interface* iface, const int& ver, const std::string& name);
@@ -26,7 +32,7 @@ class IWaylandProtocol {
Debug::log(level, std::format("[{}] ", m_szName) + std::vformat(fmt.get(), std::make_format_args(args...)));
};
- wl_listener m_liDisplayDestroy;
+ IWaylandProtocolDestroyWrapper m_liDisplayDestroy;
private:
std::string m_szName;