diff options
| author | Tom Englund <tomenglund26@gmail.com> | 2024-08-12 19:19:03 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-12 18:19:03 +0100 |
| commit | 3fa6db1e7a7f5596f449ae12d0b45ff364d7f6f1 (patch) | |
| tree | fda33f86c4706dd151e4cb17908bee60f4434d0a /src/managers/KeybindManager.cpp | |
| parent | d361fcbd85a92f0494c6d8ef0c63aad798df20a7 (diff) | |
core: fix data race and a unsigned int rollover (#7278)
* keybindmgr: avoid uint rollover on mouse keycode
mouse keycode is 0, and the switch case checks for 0 - 8 and rolls over,
just return early if keycode is 0.
* watchdog: avoid data races in watchdog
asan thread sanitizer reported data races in the watchdog from reading
and setting the bool variables make them std::atomic bools. also add a
atomic bool for the main thread to wait for to avoid data race when
reading the config values.
* hyprdebug: change non unicode character to name
asan created false positives and didnt like this bit, so for the sake of
easier debugging rename it to something unicode.
Diffstat (limited to 'src/managers/KeybindManager.cpp')
| -rw-r--r-- | src/managers/KeybindManager.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/managers/KeybindManager.cpp b/src/managers/KeybindManager.cpp index d4bac507..dba34d70 100644 --- a/src/managers/KeybindManager.cpp +++ b/src/managers/KeybindManager.cpp @@ -180,6 +180,9 @@ uint32_t CKeybindManager::stringToModMask(std::string mods) { } uint32_t CKeybindManager::keycodeToModifier(xkb_keycode_t keycode) { + if (keycode == 0) + return 0; + switch (keycode - 8) { case KEY_LEFTMETA: return HL_MODIFIER_META; case KEY_RIGHTMETA: return HL_MODIFIER_META; |
