compositor: fix ghost fadingOut windows remaining after cleanup

1 files changed, 5 insertions, 10 deletions

diff --git a/src/Compositor.cpp b/src/Compositor.cpp
index 676247a2..cdd1d15b 100644
--- a/src/Compositor.cpp
+++ b/src/Compositor.cpp
@@ -1419,19 +1419,14 @@ void CCompositor::cleanupFadingOut(const int& monid) {
         if (w->m_iMonitorID != (long unsigned int)monid)
             continue;
 
-        bool valid = windowExists(w);
+        if (!w->m_bFadingOut || w->m_fAlpha.value() == 0.f) {
 
-        if (!valid || !w->m_bFadingOut || w->m_fAlpha.value() == 0.f) {
-            if (valid) {
-                w->m_bFadingOut = false;
+            w->m_bFadingOut = false;
 
-                if (!w->m_bReadyToDelete)
-                    continue;
-
-                removeWindowFromVectorSafe(w);
-            }
+            if (!w->m_bReadyToDelete)
+                continue;
 
-            std::erase(m_vWindowsFadingOut, w);
+            removeWindowFromVectorSafe(w);
 
             Debug::log(LOG, "Cleanup: destroyed a window");
             return;